Laurent, A minor comment below. On Tuesday 26 June 2012 07:47 PM, Laurent Pinchart wrote: > Generate a stop condition after each message marked with I2C_M_STOP. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-omap.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 801df60..cf1bda0 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -545,6 +545,8 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, > if (dev->speed > 400) > w |= OMAP_I2C_CON_OPMODE_HS; > > + if (msg->flags & I2C_M_STOP) > + stop = 1; How about patching omap_i2c_xfer (caller) instead. There are some debug prints of stop above that will not reflect the real value. > if (msg->flags & I2C_M_TEN) > w |= OMAP_I2C_CON_XA; > if (!(msg->flags & I2C_M_RD)) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html