Javier Martinez Canillas <martinez.javier@xxxxxxxxx> writes: > On Fri, Jun 29, 2012 at 2:55 PM, Kevin Hilman <khilman@xxxxxx> wrote: >> +Paul >> >> Javier Martinez Canillas <javier@xxxxxxxxxxxx> writes: >> >>> commit 99b59df0 ARM: OMAP3: PM: fix shared PRCM interrupt leave disabled at boot >>> >>> set the IRQ_NOAUTOEN flag to the PCRM IO-chain irq to avoid this >>> interrupt until the PM core code is ready to handle the interrupts. >>> >>> It seems that this is not needed anymore after the OMAP PRCM I/O chain >>> code re-implementation introduced on merge commit: >>> >>> 9a17d88 Merge tag 'omap-devel-c-for-3.6' of git://git.kernel.org/pub/scm/linux/kernel/ >>> >>> The IRQ_NOAUTOEN flags is not set for the PRCM I/O irq anymore on the >>> new implementation. This has the effect that a request_irq() for the >>> PRCM I/O chain irq will auto-enable the requested IRQ and a later call >>> to enable_irq() will lead to the following warning: >> >> I noticed that warning too, but I don't think $SUBJECT patch is the >> right fix. >> >> We still need the IRQ_NOAUTOEN so that cases where PM is not enabled, >> the IO chain interrupts are not enabled. >> >> Looking closer, it looks like the merge of omap-devel-c-for-3.6 removed >> the IRQ_NOAUTOEN in the merge resolution, which wasn't right. >> >> I'll cook up a fix for this. >> >> Kevin >> >> > > Hi Kevin, > > Yes, I can confirme you that the IRQ_NOAUTOEN was gone. I didn't know > if the right solution was to set that flag again or to just remove the > duplicated enable_irq(). I should had tag my patch with RFC instead of > PATCH I guess :-) No worries. I just sent a patch adding back the IRQ_NOAUTOEN. Thanks for reporting the bug. I had noticed the boot time errors to but had not yet got to looking into them. Your patch made me dig deeper. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
