On Wednesday 27 June 2012 20:45:00 Laurent Pinchart wrote: > On Wednesday 27 June 2012 20:05:27 Laurent Pinchart wrote: > > On Wednesday 27 June 2012 10:36:04 Paul Walmsley wrote: > > > On Wed, 27 Jun 2012, Laurent Pinchart wrote: > > > > I think you've missed drivers/media/video/omap3isp/isp.c. Should I > > > > send > > > > a > > > > patch for that ? Do these changes depend on anything not yet in > > > > mainline > > > > that I should apply to my tree for testing ? > > > > > > What would be ideal is if omap3isp could be converted to runtime PM for > > > its internal IP block control. Almost all of the other OMAP on-chip oC > > > drivers have been converted. Please let us know if more information or > > > assistance is needed with this. > > > > How does that integrate with the clock framework ? > > OK, I think I've found the information. I'll give this a try. Not much luck, pm_runtime_get_sync() doesn't seem to enable the ISP clocks. I'm not familiar with runtime PM internals, what's the call stack from pm_runtime_get_sync() to the arch code that's supposed to enable clocks ? > What is still not clear to me is how runtime PM and system PM interact. For > instance the OMAP3 ISP driver disables its clocks in the system PM suspend > handler, and restarts them in the system PM resume handler. How do I port > that to runtime PM, can I just call pm_runtime_put() and > pm_runtime_get_sync() in the system PM handlers ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html