Re: [PATCH v3 4/4] memory: emif: add device tree support to emif driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 26 June 2012 10:39 AM, Shilimkar, Santosh wrote:
+#if defined(CONFIG_OF)
>  >  +static const struct of_device_id emif_of_match[] = {
>  >  +             { .compatible = "ti,emif-4d" },
>  >  +             { .compatible = "ti,emif-4d5" },
>  >  +             {},
>  >  +};
>  >  +MODULE_DEVICE_TABLE(of, emif_of_match);
>  >  +#endif
>  >  +
>  >    static struct platform_driver emif_driver = {
>  >         .remove         = __exit_p(emif_remove),
>  >         .shutdown       = emif_shutdown,
>  >         .driver = {
>  >                 .name = "emif",
>  >  +#if defined(CONFIG_OF)
>  >  +             .of_match_table = of_match_ptr(emif_of_match),
>  >  +#endif
>
>  Are these two still #if defined needed?
>
>  Also, what about the IS_DEFINED macro?
>
Yes. To avoid the build break in !DT build.


No, infact of_match_ptr is there just so you can avoid a
#ifdef around and not break !CONFIG_OF.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux