Re: [PATCH RESEND] ARM: OMAP4: hwmod data: add HWMOD_SWSUP_SIDLE to dss_hdmi to data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 21 Jun 2012, Cousson, Benoit wrote:

> Hi Ricardo,
> 
> In fact the flags attribute was not located correctly with regard to the template used by the scripts.
> I updated the script, the patch, the subject and fix a typo in the changelog.
> 
> Please find below the updated version.

Thanks, queued for 3.5-rc.

- Paul

> 
> 
> ---
> >From 9a89d06f9de9a4efbfc49d0c5adf0fa0d0031bdf Mon Sep 17 00:00:00 2001
> From: Ricardo Neri <ricardo.neri@xxxxxx>
> Date: Thu, 21 Jun 2012 10:08:53 +0200
> Subject: [PATCH] ARM: OMAP4: hwmod data: Force HDMI in no-idle while enabled
> 
> As per the OMAP4 documentation, audio over HDMI must be transmitted in
> no-idle mode. This patch adds the HWMOD_SWSUP_SIDLE so that omap_hwmod uses
> no-idle/force-idle settings instead of smart-idle mode.
> 
> This is required as the DSS interface clock is used as functional clock
> for the HDMI wrapper audio FIFO. If no-idle mode is not used, audio could
> be choppy, have bad quality or not be audible at all.
> 
> Signed-off-by: Ricardo Neri <ricardo.neri@xxxxxx>
> [b-cousson@xxxxxx: Update the subject and align the .flags
> location with the script template]
> Signed-off-by: Benoit Cousson <b-cousson@xxxxxx>
> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index aae6e5e..f51b35f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -858,6 +858,11 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = {
>  	.name		= "dss_hdmi",
>  	.class		= &omap44xx_hdmi_hwmod_class,
>  	.clkdm_name	= "l3_dss_clkdm",
> +	/*
> +	 * HDMI audio requires to use no-idle mode. Hence,
> +	 * set idle mode by software.
> +	 */
> +	.flags		= HWMOD_SWSUP_SIDLE,
>  	.mpu_irqs	= omap44xx_dss_hdmi_irqs,
>  	.sdma_reqs	= omap44xx_dss_hdmi_sdma_reqs,
>  	.main_clk	= "dss_48mhz_clk",
> -- 
> 1.7.0.4
> 
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux