On 04/24/2012 07:23 AM, Kevin Hilman wrote:
We only need to call the pre/post transtion methods when we know the power state is changing. First, split up the pre/post transition calls to be per-powerdomain, and then make them conditional on whether the power domain is actually changing states. Signed-off-by: Kevin Hilman<khilman@xxxxxx>
This patch introduced a regression where the transition counts for NEON were no longer accurate because I forgot to call the notifiers for NEON when calling them for MPU.
The diff below will be folded into this patch before submitting for v3.6. Kevin diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 8bd7daf..6226d10 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -306,8 +306,10 @@ void omap_sram_idle(void) omap3_enable_io_chain(); } - if (mpu_next_state < PWRDM_POWER_ON) + if (mpu_next_state < PWRDM_POWER_ON) { pwrdm_pre_transition(mpu_pwrdm); + pwrdm_pre_transition(neon_pwrdm); + } /* PER */ if (per_next_state < PWRDM_POWER_ON) { @@ -391,8 +393,10 @@ void omap_sram_idle(void) omap3_disable_io_chain(); } - if (mpu_next_state < PWRDM_POWER_ON) + if (mpu_next_state < PWRDM_POWER_ON) { pwrdm_post_transition(mpu_pwrdm); + pwrdm_post_transition(neon_pwrdm); + } } static void omap3_pm_idle(void) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html