Re: [PATCH] OMAP: beagle: Set USB Host Port 1 to OMAP_USBHS_PORT_MODE_UNUSED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 18, 2012 at 2:42 PM, Brian Austin <brian.austin@xxxxxxxxxx> wrote:
> The beagleboard USB Host Port that is used is Port 2. The platform driver sets MODE_PHY for port 1 causing pin muxing to override the pins on the expansion
> connector P17 when using board_mux[]. Since USBHS Port 1 is not connected remove the case for muxing the USB Port1 pins by default.
>
> Patch is based off of 3.5-rc2 from ASoC for-next branch
>
> Tested with BeagleBoard xM revC and checked the userguides for Beagle xM and revC to be sure USB Port2 is what is used.
>
> Singed-off-by: Brian Austin <brian.austin@xxxxxxxxxx>

You'll probably have to fix your sing/sign typo, but otherwise it looks good

Acked-by: Russ Dill <Russ.Dill@xxxxxx>

Just for those that might get confused looking at schematics,
port_mode[0] refers to the HSUSB1_* pins, and port_mode[1] refers to
the HSUSB2_* pins.

> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 79c6909..75eb88a 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -435,7 +435,7 @@ static struct platform_device *omap3_beagle_devices[] __initdata = {
>
>  static const struct usbhs_omap_board_data usbhs_bdata __initconst = {
>
> -       .port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
> +       .port_mode[0] = OMAP_USBHS_PORT_MODE_UNUSED,
>        .port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
>        .port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
>
> --
> 1.7.10.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux