Re: [RFC] ARM: OMAP4470: Fix OMAP4470 boot failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jon,

On Thu, 7 Jun 2012, Jon Hunter wrote:

> The problem is that currently none of the clocks are being registered for
> OMAP4470 devices and so on boot-up no clocks can be found and the kernel panics.
> 
> This fix always the kernel to boot without failure using a simple RAMDISK file
> system. However, I need some inputs from the clock guru's if this is the
> correct fix :-)
> 
> Signed-off-by: Jon Hunter <jon-hunter@xxxxxx>

I guess Benoît should make the call on this, since he's got access to the 
hardware data to use to autogenerate these clocks.  If there aren't any 
differences between the 4460 and 4470 clocks and dividers, then your 
patch looks good to me.  

If there are any differences between the 4460 and 4470 clocks and 
dividers, we should probably wait until the common clock conversion is 
complete, since that would presumably be a large change.

Just my 2 cents, 

- Paul


> ---
>  arch/arm/mach-omap2/clock44xx_data.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index 2172f66..19275e8 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -3412,7 +3412,7 @@ int __init omap4xxx_clk_init(void)
>  	if (cpu_is_omap443x()) {
>  		cpu_mask = RATE_IN_4430;
>  		cpu_clkflg = CK_443X;
> -	} else if (cpu_is_omap446x()) {
> +	} else if (cpu_is_omap446x() || cpu_is_omap447x()) {
>  		cpu_mask = RATE_IN_4460 | RATE_IN_4430;
>  		cpu_clkflg = CK_446X | CK_443X;
>  	} else {
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


- Paul

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux