On Sat, 2012-06-16 at 03:31 +0530, jaswinder.singh@xxxxxxxxxx wrote: > From: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > Explicitly maintaining HDMI phy power state using a flag is prone to > race and un-necessary when we have a zero-cost alternative of checking > the state before trying to set it. Why would reading the value from the register be any less racy than keeping it in memory? And reading from memory is probably much faster than reading from an HDMI register, so I'm not sure what you mean with zero-cost. But I guess it is simpler, so in that sense the patch is ok. But please revise the description. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part