Hi Jon, On Wed, Jun 13, 2012 at 21:09:52, Hunter, Jon wrote: > Sure, but reviewing the function it still looks odd from a readability > standpoint. At least it made me think "what is going on here ...". So a > comment is definitely needed. > > >> > >> 2. A bad setting in the configuration passed. Hopefully, people will > >> stick to the flags but we know that we expect the device type to be a 0 > >> or 2 and so should we check? > > > > Value of device type is something driver has to worry about, not its users, > > they have been provided with two flags, one for NAND & other for NOR. > > Yes, but the driver does not seem to worry about it. In other words, > there is no error checking. Ok so not a big deal a comment should suffice. Ok, comments will be added to make intentions clear Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
