Hi Jon, On Tue, Jun 12, 2012 at 23:36:17, Hunter, Jon wrote: > Well it is unclear what the code flow is for using this helper as this > change simply adds the helper. If someone other function is writing to > the CONFIG1 register before this function, then you may wish to > highlight the programming sequence in the changelog or at least describe > why this function performs a read-modify-write and not just a write. Logic followed here: CS configuration helper needs to worry only about bits that are relevant for CS configuration and don't alter any other bits/registers. Same is applicable for time setting helper. Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html