On 06/12/2012 02:16 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Tue, Jun 12, 2012 at 02:13:22, Hunter, Jon wrote: > >>> + gpmc_revision = (l >> 4) & 0xf; >> >> Why are you only storing the major part of the rev? Why not keep both parts? > > Does having minor revision add any value ?, at least as of now, > I do not see any. May be not but it does not hurt either. >>> + dev_info(gpmc_dev, "GPMC revision %d.%d\n", gpmc_revision, l & 0x0f); >> >> Nit-pick, please add a mask and shift definition for the revision >> register major and minor fields and use these above. > > Yes, right Thanks Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
