Hi Jon, On Tue, Jun 12, 2012 at 03:57:45, Hunter, Jon wrote: > > + if (p->cycle2cyclesamecsen) > > + l |= GPMC_CONFIG6_CYCLE2CYCLESAMECSEN; > > + else > > + l &= ~GPMC_CONFIG6_CYCLE2CYCLESAMECSEN; > > + if (p->cycle2cyclediffcsen) > > + l |= GPMC_CONFIG6_CYCLE2CYCLEDIFFCSEN; > > + else > > + l &= ~GPMC_CONFIG6_CYCLE2CYCLEDIFFCSEN; > > + gpmc_cs_write_reg(cs, GPMC_CS_CONFIG6, l); > > +} > > How about adding a sub-function like ... Agree, that is better. Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html