Hi Jon,
On Tue, Jun 12, 2012 at 01:26:29, Hunter, Jon wrote:
> > + pdev = omap_device_build(name, -1, oh, pdata,
> > + sizeof(*pdata), NULL, 0, 0);
> > + if (IS_ERR(pdev)) {
> > + WARN(1, "Can't build omap_device for %s:%s.\n",
> > + name, oh->name);
> > + return PTR_ERR(pdev);
> > + }
> > +
> > + gpmc_l3_clk = clk_get(NULL, oh->main_clk);
> > + if (IS_ERR(gpmc_l3_clk)) {
> > + pr_err("Could not get GPMC clock\n");
> > + return PTR_ERR(gpmc_l3_clk);
> > + }
>
> My preference would be to store gpmc_l3_clk in the pdata and pass to
> probe via the pdata. The aim would be to remove the global gpmc_l3_clk
> altogether.
For timing calculation by platform outside of driver, we need clk rate
> Also we should attempt to get the clk before calling omap_device_build
> which is registering the driver.
omap_device_build registers only device, but I agree that clk should
be obtained before it as driver can get probed at that point
Regards,
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
