On 06/11/2012 09:26 AM, Afzal Mohammed wrote:
> Helpers for propulating given resource structure
> with memory & interrupt information.
>
> Signed-off-by: Afzal Mohammed <afzal@xxxxxx>
> ---
> arch/arm/mach-omap2/gpmc.c | 45 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index a91f40f..652b245 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -905,6 +905,51 @@ static void __devinit gpmc_mem_init(void)
> }
> }
>
> +static __devinit int gpmc_setup_cs_mem(struct gpmc_cs_data *cs,
> + struct resource *res)
> +{
> + unsigned long start;
> + int ret;
> +
> + ret = gpmc_cs_request(cs->cs, cs->mem_size, &start);
> + if (IS_ERR_VALUE(ret)) {
> + dev_err(gpmc_dev, "error: gpmc request on CS: %d\n", cs->cs);
> + return ret;
> + }
> +
> + res->start = start + cs->mem_offset;
> + res->end = res->start + cs->mem_size - 1;
> + res->flags = IORESOURCE_MEM;
> +
> + dev_info(gpmc_dev, "memory 0x%x-0x%x on CS %d\n", res->start,
> + res->end, cs->cs);
> +
> + return 1;
> +}
Nit-pick, CodingStyle chapter 16 states that 0 should be used for
success when returning from a function.
> +
> +static inline unsigned gpmc_bit_to_irq(unsigned bitmask)
> +{
> + return bitmask;
> +}
I have to ask what is the value in this helper function? ;-)
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
