Hi Will, On 06/06/2012 12:33 PM, Will Deacon wrote: > On Tue, Jun 05, 2012 at 02:19:02PM +0100, Jon Hunter wrote: >> Hi Will, > > Hi Jon, > >> On 06/04/2012 04:44 PM, Jon Hunter wrote: >> Anyway, let me know what you think of this approach. An alternative is >> to put the calls pm_runtime_get/put outside of the reserve/release_pmu, >> which would be a simpler change, but I was thinking that the above maybe >> more aligned with your thinking. > > Ok, thanks for this. Whilst your code is definitely more like I'm > envisaging, you're right about the churn and until I've sorted out the > reservation code so that it's a callback via the PMU structure, it is > overly messy. > > So for the time being let's do what you suggested and put the suspend/resume > calls into armpmu_{reserve,release}_hardware. We can still kill the irq > enable/disable calls and I can rework this slightly when I change the > reservation code. Sounds good. I will send out my V2 series tomorrow that will include the above change. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html