Re: [PATCH] OMAP: Beagle: fix DVI GPIO request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:

> Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> powerdown-gpio handling from the board files to the tfp410 driver. One
> gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> the Beagle board file. This causes the tfp410 driver to fail to request
> the gpio on Beagle, causing the driver to fail and thus the DVI output
> doesn't work.
> 
> This patch removes the gpio_request_one() from the board file.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 8ede8d2..72ad1f6 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> 	omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> 				  mt46h32m32lf6_sdrc_params);
> 
> +	/* DVI power down GPIO */
> 	omap_mux_init_gpio(170, OMAP_PIN_INPUT);

Wouldn't it be an output rather than an input?

regards,

Koen--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux