On Thu, May 17, 2012 at 1:44 AM, Jon Hunter <jon-hunter@xxxxxx> wrote:
> Hi Benoit,
>
> On 05/16/2012 04:28 AM, Cousson, Benoit wrote:
>> Hi Jon,
>>
>> On 5/16/2012 1:35 AM, Jon Hunter wrote:
>>> From: Jon Hunter<jon-hunter@xxxxxx>
>>>
>>> In order to migrate the dmtimer driver to support device-tree I found
>>> that it
>>> was first necessary to clean-up the timer platform data. The goal of this
>>> series is to simplify the timer platform data structure from ...
>>>
>>> struct dmtimer_platform_data {
>>> int (*set_timer_src)(struct platform_device *pdev, int source);
>>> int timer_ip_version;
>>> u32 needs_manual_reset:1;
>>> bool reserved;
>>> bool loses_context;
>>> int (*get_context_loss_count)(struct device *dev);
>>> };
>>>
>>> to ...
>>>
>>> struct dmtimer_platform_data {
>>> int (*set_timer_src)(struct platform_device *pdev, int source);
>>
>> I guess that custom set_timer_src should not be there at all anymore.
>> Well at least for OMAP2+.
>> We should just use the regular clock API to change the parent. I do not
>> see why we should add that wrapper on top of the clock API and thus
>> store some internal clock name inside the timer device init code.
Whatever is done within omap2_dm_timer_set_src() in mach-omap2/timer.c
can be implemented inside omap_dm_timer_set_source() in plat-omap/dmtimer.c
directly whereby we continue to use the generic clock APIs provided in
include/linux/clk.h.
>
> I have been looking into this and in order to get rid for the above
> function pointer we would need to move at a minimum the following
> functions from omap-mach2/clkt_clksel.c into the platform code.
>
> _get_clksel_by_parent()
> _get_div_and_fieldval()
> _write_clksel_reg()
> omap2_init_clksel_parent()
> omap2_clksel_set_parent()
>
> However, it may be simpler just to move the clkt_clksel.c file
> completely. I have tested the above functions on omap1 and they are
> working well. However, before doing this we would need to get Paul's
> buy-in that this is the right thing to do.
I am not sure if this is really needed though.
--
Tarun
>
> Paul, do you have any thoughts on this? We were trying to see if we
> could eliminate the dmtimer function pointer for setting the timer clock
> source.
>
> Also, the only other minor issue I see is that for omap1 devices instead
> of having "sys_ck" as the name the clock name is "armxor_ck". We cannot
> rename armxor_ck as it is used by many peripherals but we could use a
> #define to workaround this or add a dummy clock node.
>
> Cheers
> Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
