On Fri, 2012-05-04 at 12:29 -0700, Tony Lindgren wrote:
> * Tomi Valkeinen <tomi.valkeinen@xxxxxx> [120425 05:32]:
> > On Tue, 2012-04-24 at 10:16 -0700, Tony Lindgren wrote:
> > > * Tomi Valkeinen <tomi.valkeinen@xxxxxx> [120423 00:43]:
> > > > Add statics to board-omap4-panda.c's internal functions and data
> > > > structures to remove warnings.
> > >
> > > Care to update with the warnings produced?
> >
> > Ah, sure. Updated patch below:
> >
> > From e96ddeb7d783d48a15a32f8ef5a7bae3089f66b9 Mon Sep 17 00:00:00 2001
> > From: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> > Date: Wed, 28 Mar 2012 11:38:58 +0300
> > Subject: [PATCH] OMAP4: panda: add statics to remove warnings
> >
> > Add statics to board-omap4-panda.c's internal functions and data
> > structures to remove sparse warnings:
> >
> > arch/arm/mach-omap2/board-omap4panda.c:234:29: warning: symbol
> > 'omap_panda_wlan_data' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:441:24: warning: symbol
> > 'omap4_panda_dvi_device' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:451:12: warning: symbol
> > 'omap4_panda_dvi_init' was not declared. Should it be static?
> > arch/arm/mach-omap2/board-omap4panda.c:512:13: warning: symbol
> > 'omap4_panda_display_init' was not declared. Should it be static?
>
> Thanks adding to fixes-non-critical.
It seems this patch is obsolete, as there's already one in linux-next:
commit 8c3d4534a8da0dc6a2d52b61585e61f7e8143096
Author: Paul Walmsley <paul@xxxxxxxxx>
Date: Fri Apr 13 06:34:26 2012 -0600
ARM: OMAP2+: declare file-local functions as static
Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
