On Fri, May 04, 2012 at 02:02:43PM -0700, Kevin Hilman wrote: > "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx> writes: > > > On Fri, May 04, 2012 at 07:31:30AM -0700, Kevin Hilman wrote: > > [...] > > >> Come to think of it, the right solution here is probably to use runtime > >> PM. We could then to add some custom hooks for davinci_emac in the > >> device code to use enable_hlt/disable_hlt based on activity. > > > > That was my first thought, actually, but that only works if its > > okay for the driver to call enable_hlt/disable_hlt directly (i.e., > > have runtime_suspend() call enable_hlt() and runtime_resume() call > > disable_hlt()). However, I assumed it would _not_ be acceptable for > > the driver to issue those calls directly. > > I agree. > > > Its a platform-specific issue that we shouldn't be polluting the > > driver with and there are currently no drivers that call them under > > the drivers directory. > > Using runtime PM we don't have to have any platform specific calls in > the driver. We handle it inside the platform-specific runtime PM > implementation. FYI, with some further discussion via IRC, I'm going to implement what Kevin has laid out here. There is a dependency on davinci adding support too but I'll coordinate with the people/person doing that. Please disregard this patch. Thanks for the help everyone. Mark -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
