Re: [PATCH-V6 1/3] ARM: OMAP1: FIX: check possible error condition in timer_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

* Kevin Hilman <khilman@xxxxxx> [120502 13:11]:
> Vaibhav Hiremath <hvaibhav@xxxxxx> writes:
> 
> > OMAP1, omap_32k_timer_init() function always returns "true",
> > irrespective of whether error occurred while initializing 32k sync
> > counter as a kernel clocksource or not and execution will never
> > fallback to mpu_timer clocksource init code.
> >
> > This patch adds check for return value from function
> > omap_init_clocksource_32k(), and fallback to omap_mpu_timer_init()
> > in case of failure/error from omap_init_clocksource_32k().
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> > Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> > Cc: Kevin Hilman <khilman@xxxxxx>
> > Cc: Paul Walmsley <paul@xxxxxxxxx>
> > Cc: Benoit Cousson <b-cousson@xxxxxx>
> > ---
> > This is new patch addition compared to original series (<=V5).
> >
> > Also, note that, this patch is only compile tested, since
> > I do not have omap1 board with me to validate it.
> > Kevin, can you help me to validate it.
> 
> I boot tested on OMAP1 (5912/OSK) with 32k timer and MPU timer
> Kconfigs.  Works fine, but needs small change below for compile warnings.
> 
> Otherwise, looks good.

We need at least one tested-by on some 15xx platform for these changes.
Janusz, can you please give this series a try on your board too?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux