On 05/03/2012 10:34 PM, Kevin Hilman wrote:
Daniel Lezcano<daniel.lezcano@xxxxxxxxxx> writes:
Define a CPU_IDLE section in the makefile, declare the functions in
the header files conforming to the kernel coding rules and remove the
'define's in the C files.
Signed-off-by: Daniel Lezcano<daniel.lezcano@xxxxxxxxxx>
Reviewed-by: Jean Pihet<j-pihet@xxxxxx>
This patch breaks compilation for the !CONFIG_PM case:
arch/arm/mach-omap2/built-in.o: In function `__omap3_enter_idle':
/work/kernel/omap/pm/arch/arm/mach-omap2/cpuidle34xx.c:121: undefined reference to `omap_sram_idle'
Since you moved this stuff out of a CONFIG_PM conditional part of the
Makefile, it broke because pm34xx.c is still compiled conditionally on
CONFIG_PM.
When changing Makefile/Kconfig dependencies like this, please
be sure to at least compile test with the various options
enabled/disabled.
For now, I've dropped this patch from the series. Feel free to
update/retest/resend since the idea is fine.
Ok, I will update it with the various options.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
