Re: [PATCH v2] arm: omap4: hsmmc: check for null pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2012 at 8:13 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Mon, Apr 23, 2012 at 08:11:07PM +0530, Balaji T K wrote:
>> +int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
>> +{
>> +     struct omap2_hsmmc_info *c;
>> +
>> +     omap_hsmmc_init(controllers);
>> +     for (c = controllers; c->mmc; c++) {
>> +             /* pdev can be null if CONFIG_MMC_OMAP_HS is not set */
>> +             if (!c->pdev)
>> +                     continue;
>> +             omap4_twl6030_hsmmc_set_late_init(&c->pdev->dev);
>> +     }
>> +
>> +     return 0;
>> +}
>
> why are you even calling this if CONFIG_MMC_OMAP_HS isn't set ? Just
> stub it out if you don't have mmc support.

Ok, added in v3
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux