* Tero Kristo <t-kristo@xxxxxx> [120420 02:38]: > -void omap4_sar_overwrite(void) > +void omap_sar_overwrite(void) > { > u32 val = 0; > - u32 offset = 0; > + u32 usb_offset = 0x2ec; > + u32 usb_offset2 = 0x91c; > > - if (cpu_is_omap446x()) > - offset = 0x04; > + if (cpu_is_omap446x()) { > + usb_offset = 0x2f4; > + usb_offset2 = 0x920; > + } Here too you should initialized these during __init. Otherwise we'll end up piling more and more if else cpu_is_omapxxxx for future omaps that again might change the offsets. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html