Hi On Fri, 20 Apr 2012, Govindraj.R wrote: > From: "Govindraj.R" <govindraj.raja@xxxxxx> > > On 24xx/34xx/36xx Module level wakeup events are enabled/disabled using > PM_WKEN1_CORE/PM_WKEN_PER regs. The module level wakeups are enabled by > default, by PRM soft reset default value of PM_WKEN reg is all one's which means > all module level wakeups are enabled. > > However the wakeups can be enabled/disabled using sysfs entry example for uart: > echo disabled > /sys/devices/platform/omap/omap_uart.X/power/wakeup > [X=0,1,2,3] > > So expand omap2 prcm structure to incorporate the PM_WKEN reg offset > and bit mask to control the module level wakeup. This info from hwmod > data can be used from hwmod framework in omap_hwmod_enable/disable_wakeup > api's to configure module level wakeups. > > Cc: Paul Walmsley <paul@xxxxxxxxx> > Cc: Kevin Hilman <khilman@xxxxxx> > Cc: Benoit Cousson <b-cousson@xxxxxx> > Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> This patch is not needed. The data contained in your .module_wakeup_offs field can be calculated from the existing struct omap_hwmod.prcm.omap2 fields, specifically .prcm_reg_id and .module_offs. And the module_wakeup_bit shift should be identical to the .module_bit, so there should be no need for a separate field for that either. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html