On Fri, Apr 20, 2012 at 12:12:27PM +0100, Grazvydas Ignotas wrote: > On Fri, Apr 20, 2012 at 12:48 PM, Ivan Djelic <ivan.djelic@xxxxxxxxxx> wrote: > > Hello, > > This patch provides hardware NAND BCH ecc support for OMAP3 boards. > > It depends on the following patches: > > > > new GPMC BCH api (linux-omap): > > http://lists.infradead.org/pipermail/linux-mtd/2012-April/040757.html > > > > race condition fix in OMAP mtd driver: > > http://lists.infradead.org/pipermail/linux-mtd/2012-April/040724.html > > I don't have this one in my mailbox (looked up through the archives), > so commenting about it here. What about just dropping omap_wait() > instead? I think gpmc_nand_read(.. GPMC_NAND_DATA) is equivalent to > ordinary data read, knowing that omap_wait() looks like a duplicate of > generic nand_wait(), just without LED support. Yes, I agree; I also comtemplated getting rid of omap_wait(), but I needed this quick fix out of the way to submit my BCH patch. But you're right, and there are plenty other things to improve in omap2.c (look at omap_compare_ecc() for a good example). BR, -- Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
