"Raja, Govindraj" <govindraj.raja@xxxxxx> writes: > On Wed, Apr 18, 2012 at 4:55 AM, Kevin Hilman <khilman@xxxxxx> wrote: >> "Govindraj.R" <govindraj.raja@xxxxxx> writes: >> >>> From: "Govindraj.R" <govindraj.raja@xxxxxx> >>> >>> The wakeups can be left enabled by default and should be disabled >>> only when disabled from sysfs and while entering suspend. >> >> Left enabled? That assumes something else has initizlied them, but we >> can't make that assumption. >> >> First, wakeups should be disabled when ->probe has finished. Then, >> they should be enabled whenever driver is in use, and disabled when >> the driver is not in use. >> >> I'm not familiar enough with uart_ops, but it looks like they should >> probably be enabled in uart_ops->startup and disabled in >> uart_ops->shutdown. > > uart_ops->shutdown gets called in suspend path also > serial_omap_suspend => uart_suspend_port = > ops->shutdown(uport); > > This will leave uart wakeup disabled in suspend path. As I said, I'm not familiar enough with uart_ops to know which are the right ones. Maybe ->request_port and ->release_port are the right ones? The point is that wakeups should be enabled whenever driver is in use, and disabled when the driver is not in use. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
