Re: [PATCH 1/3] ARM: OMAP: dmtimer: Use devm_ API and do some cleanup in probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 16, 2012 at 8:32 PM, Shubhrajyoti <shubhrajyoti@xxxxxx> wrote:
> On Monday 16 April 2012 05:55 PM, Tarun Kanti DebBarma wrote:
>> Replace the regular kzalloc and ioremap with the devm_ equivalent
>> to simplify error handling. We don't need kree() anymore in
>> omap_dm_timer_remove().
>>
>> Also added *dev* pointer to reference pdev->dev which makes the
>> usage shorter in code.
>>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx>
>> ---
>>
> <snip>
>> -     timer->io_base = ioremap(mem->start, resource_size(mem));
>> +     timer->io_base = devm_ioremap(dev, mem->start, resource_size(mem));
>>       if (!timer->io_base) {
> Could we use  devm_request_and_ioremap here?
>
Yes, I will change. Thanks.
--
Tarun
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux