Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes: > On Wed, Apr 04, 2012 at 03:20:22PM -0700, Kevin Hilman wrote: >> Hi Dave, >> >> On 03/26/2012 05:19 PM, Kevin Hilman wrote: >>> The OMAP driver needs a 'depends on ARCH_OMAP2PLUS' since it only >>> builds for OMAP2+ platforms. >>> >>> This 'depends on' was in the original patch from Russell King, but was >>> erroneously removed by me when making this option user-selectable in >>> commit b09db45c (cpufreq: OMAP driver depends CPUfreq tables.) This >>> patch remedies that. >>> >>> Apologies to Russell King for breaking his originally working patch. >>> >>> Also, thanks to Grazvydas Ignotas for reporting the same problem. >>> >>> Cc: Russell King<rmk+kernel@xxxxxxxxxxxxxxxx> >>> Cc: Grazvydas Ignotas<notasas@xxxxxxxxx> >>> Signed-off-by: Kevin Hilman<khilman@xxxxxx> >>> --- >>> Dave, this applies on top of your current fixes branch, and fixes a >>> problem introduced there by me. Please merge for v3.4-rc. Thanks. >> >> Can you pick this up for v3.4-rc? > > Right, I'm fed up with chasing over this trivial patch. It's been almost > a full month since the problem was first reported and it _still_ remains > unfixed in mainline, despite me chasing over it. So, sorry, you lose. > > I'm merging my fix (attached) which I've been running against the nightly > builds into my fixes branch and will ask Linus to pull it this weekend. > If you want something else, then please send a patch on top of my fix to > do what you want. > > Alternatively, send a replacement fix to Linus _before_ Sunday evening > copying me with it and I'll drop this from my tree. But I want to see > an alternative going to Linus for that to happen. I've (re)sent the patches now. I just resent the CPUfreq driver Kconfig fix, this time directly to Linus. I also just resent the arch/arm/mach-omap2 one to Tony/Paul with a slightly updated changelog making it clear that removing that dead code also fixes build errors so it can be queued ASAP for v3.4-rc. Combined, those fix the problems your patch addresses. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
