Can someone tell me how this works with the current omap-serial driver please? It looks to me like this has been broken when DMA support was added to the driver. Moreover, please look at the probe function error paths. They seem to be lacking any kind of realistic cleanup, so are a potential memory leak. Then there's the issue of fiddling with the xmit buffer so that it's using coherent memory in the startup and shutdown functions (why? when other serial drivers cope just fine without doing this). If we want to use DMA coherent memory there, there should be a clean way to do this, rather than going behind the upper layers. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html