Hi Felipe,
On Wed, Apr 11, 2012 at 5:05 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Wed, Apr 11, 2012 at 04:42:52PM +0530, Shubhrajyoti D wrote:
>> Use SET_RUNTIME_PM_OPS macro to set runtime functions.
>>
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
>> ---
>> drivers/i2c/busses/i2c-omap.c | 11 ++++-------
>> 1 files changed, 4 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>> index dd65416..28de1d2 100644
>> --- a/drivers/i2c/busses/i2c-omap.c
>> +++ b/drivers/i2c/busses/i2c-omap.c
>> @@ -1217,15 +1217,12 @@ static int omap_i2c_runtime_resume(struct device *dev)
>>
>> return 0;
>> }
>> +#endif
>>
>> static struct dev_pm_ops omap_i2c_pm_ops = {
>> - .runtime_suspend = omap_i2c_runtime_suspend,
>> - .runtime_resume = omap_i2c_runtime_resume,
>> + SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
>> + omap_i2c_runtime_resume, NULL)
>> };
>> -#define OMAP_I2C_PM_OPS (&omap_i2c_pm_ops)
>> -#else
>> -#define OMAP_I2C_PM_OPS NULL
>> -#endif
>
> I think you should keep this define, otherwise the pm pointer will
> always be valid.
Will correct it .
Thanks,
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
