On Wed, Apr 11, 2012 at 05:29:07PM +0530, Shubhrajyoti Datta wrote: > Hi Felipe, > > On Wed, Apr 11, 2012 at 5:02 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > On Wed, Apr 11, 2012 at 04:42:39PM +0530, Shubhrajyoti D wrote: > >> The functions omap_i2c_unidle/idle are called from omap_i2c_runtime_resume > >> and omap_i2c_runtime_suspend which is compiled for CONFIG_PM_RUNTIME. > >> This patch removes the omap_i2c_unidle/idle functions and folds them > >> into the runtime callbacks. > >> > >> This fixes the below warn when CONFIG_PM_RUNTIME is not defined > >> > >> CC arch/arm/mach-omap2/board-ti8168evm.o > >> drivers/i2c/busses/i2c-omap.c:272: warning: 'omap_i2c_unidle' defined but not used > >> drivers/i2c/busses/i2c-omap.c:293: warning: 'omap_i2c_idle' defined but not used > >> CC net/ipv4/ip_forward.o > >> > >> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > > > > how about just moving them into the #ifdef ? /me thinks it's easier to > > read with the function. Matter of taste though, it's not that much code. > > Kevin preferred folding into the runtime functions. > > http://www.spinics.net/lists/linux-omap/msg62764.html > > Don't feel strongly though. ok, I stand corrected ;-) No need to change your patch again ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
