Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> writes: > We are storing the 'omap4_idle_data' in the private data field > of the cpuidle device. As we are using this variable only in this file, > that does not really make sense. Let's use the global variable directly > instead dereferencing pointers in an idle critical loop. Did you notice a performance impact before this change? > Also, that simplfies the code. possibly, but at the expense of clean abstractions which IMO helps readability. Unless there is a real performance hit here (which I doubt), I'd prefer to leave this as is. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
