Re: [rtc-linux] [PATCH] RTC: twl6030: correct usage of static register while reading time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Mar 2012 16:34:01 -0500
Nishanth Menon <nm@xxxxxx> wrote:

> From: Konstantin Shlyakhovoy <x0155534@xxxxxx>
> 
> RTC stores time and date in several registers. Due to the fact that
> these registers can't be read instantaneously, there is a chance
> that reading from counting registers gives an error of one minute,
> one hour, one day, etc.
> 
> To address this issue, the RTC has hardware support to copy the
> RTC counting registers to static shadowed registers.
> The current implementation does not use this feature, and in a
> stress test,  we can reproduce this error at a rate of around
> two times per 300000 readings.
> 
> Fix the implementation to ensure that the right snapshot of time
> is captured.

hey, nice changelog!

Please cc me on rtc patches - I tend to be a bit slow reading the
rtc-linux list.

> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: Benoit Cousson <b-cousson@xxxxxx>
> Cc: linux-omap <linux-omap@xxxxxxxxxxxxxxx>
> Acked-by: Mykola Oleksiienko <x0174904@xxxxxx>
> Acked-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@xxxxxx>
> Acked-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
> Acked-by: Nishanth Menon <nm@xxxxxx>
> Signed-off-by: Konstantin Shlyakhovoy <x0155534@xxxxxx>

I rewrote your acked-by to Signed-off-by, because you were on the
delivery path of the patch. Documentation/SubmittingPatches has details.

Is this OK?

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux