Re: [PATCH] ARM: OMAP2+: PRM: fix compile for OMAP4-only build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 5 Apr 2012, Kevin Hilman wrote:

> For OMAP4 only builds, the omap2_prm_* functions have dummy wrappers
> to detect incorrect usage.  However, several unrelated omap3 PRM
> functions have made it inside the #else clause of the #ifdef wrapping
> the omap2_prm stubs, causing them to disappear on OMAP4-only builds.
> 
> This was unnoticed until the IO chain support was added and introduced
> a new function in this section which is referenced by omap_hwmod.c:
> 
> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c: In function '_reconfigure_io_chain':
> /work/kernel/omap/dev/arch/arm/mach-omap2/omap_hwmod.c:1665:3: error: implicit declaration of function 'omap3xxx_prm_reconfigure_io_chain' [-Werror=implicit-fungiction-declaration]
> 
> Fix by using the #ifdef to only wrap the omap2_prm functions that
> need stubs on OMAP4-only builds.
> 
> Cc: Paul Walmsley <paul@xxxxxxxxx>
> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
> ---
> Paul, this patch applies on top your io_chain_devel_3.5 branch.

Thanks, Tony reported this too.  Any objections to me rolling this into 
the offending patch?
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux