On 03/28/12 12:53, Raja, Govindraj wrote: > On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi <balbi@xxxxxx> wrote: >> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: >>> When PHY reset pin is connected to a GPIO on external GPIO chip >>> (e.g. I2C), we should not call the gpio_set_value() function, but >>> gpio_set_value_cansleep(). >>> >>> Signed-off-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> >> >> Acked-by: Felipe Balbi <balbi@xxxxxx> >> >> Keshava, please give us your tested-by. Patch looks fine to me. > > Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller > relies gpio nreset sequence for initialization. > > Both hub + Ethernet controller get enumerated even after this patch. > > Tested-by: Govindraj.R <govindraj.raja@xxxxxx> Thanks Raja. -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html