Hi Benoit, On Fri, Mar 23, 2012 at 21:09:21, Cousson, Benoit wrote: > But EMIF does not have anything to do in MFD either :-) > > What was the feedback for this series? > > We discussed that at Linaro connect, but it looks like MFD is becoming > the place for miscellaneous drivers that we do not know where to put. > > Maybe we should introduce a driver/memory/ directory for memory > controller. At least for EMIF. > In the case of GMPC, it is slightly different because it can handle > NOR/NAND memory but as well behave like an ISA bus controller for > Ethernet ISA chip. > But since it can control several devices thanks the chipselects lines it > has, it behaves like a multi-protocol bus controller. > But in anycase, it does not look like an MFD for my point of view. For > me a MFD is like a small soc, it does contain several completely > unrelated block (Power, Audio, GPIO...), but does share some memory > space / IRQ lines. > > Is this the only controller doing that kind of stuff in the kernel so far? An additional intention of sending RFC early was to find out whether selection of MFD was acceptable. Coding so far has been done so that it can easily move to MFD or other types. Frankly I had not done much research on where GPMC driver should belong, my thought was first convert it into a driver (but vaguely in mind it may have to go to MFD), later decide on where it should go. Probably task of finding correct place for GPMC driver should happen in parallel with driver conversion. For davinci EMIF, afaik, no conclusion has been reached yet. I will try to find whether there is anything similar already in Kernel, and find out a suitable place for GPMC driver. > > If an initial patch just to rearrange the code to have similar section > > together& then new changes in a another patch, would that be fine? > > Well, if this is just comestic, I will even do that after the driver > conversion. Because if you do that before you will move some piece of > code that you might completely delete later. So you should fix the code > first and then potentially, move some part if that will improve the > readability. Ok Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
