Hi Russ, Mark,
On 03/22/12 20:29, Russ Dill wrote:
> On Thu, Mar 22, 2012 at 4:37 AM, Mark Brown
> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> On Wed, Mar 21, 2012 at 10:19:54PM -0700, Russ Dill wrote:
>>
>>> +static struct regulator_consumer_supply dummy_supplies[] = {
>>> + REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
>>> + REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),
>>
>> Why do none of these boards use -1 as the ID for the device?
>
> Commit 21b42731 (omap: convert boards that use SMSC911x to use
> gpmc-smsc911x) changed several board files to use the gpmc-smsc911x.c
> common code rather than register the device themselves, in the process
> it changed many of the id's from -1 to 0. This happened in the 3.0
> merge window. I can certainly change it back.
IIRC, everybody were very sensible to each new l-o-f back then,
so making the id = 0 (leaving it uninitialized) helped with
reducing some ~10 lines more...
Of course we can change this now, but what is the real problem
with having device id = 0 and not -1?
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
