Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes: > In _enable_gpio_irqbank() when bank->regs->set_irqenable is valid, > gpio_mask can be directly set by writing to set_irqenable register > without overwriting current value. In order to ensure the same is > stored in context.irqenable1, we must read from regs->irqenable > instead of overwriting it with gpio_mask. > The overwriting makes sense only in the second case where irqenable > is explicitly read and updated with new gpio_mask before writing it > back. However, for consistency reading regs->irqenable into the > bank->context.irqenable1 takes care of both the scenarios. ...except that the code doesn't do this anymore. I like the newer version (I hope so, since I suggested it :), but please update the changlog to describe what the code is actually doing. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
