On Mon, Mar 19, 2012 at 4:39 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > > On 19-03-2012 14:06, Felipe Balbi wrote: > >>> + ver = usbtll_read(base, OMAP_USBTLL_REVISION); >>> + if (ver == OMAP_USBTLL_REV1) >>> + count = OMAP_TLL_CHANNEL_COUNT; >>> + else if (ver == OMAP_USBTLL_REV2) >>> + count = OMAP_REV2_TLL_CHANNEL_COUNT; >>> + else { >>> + dev_err(dev, "TLL version failed\n"); >>> + ret = -ENODEV; >>> + goto err_ioremap; >>> + } > > >> wrong coding style. > > > And *switch* seems more fitting here. > > WBR, Sergei Thanks , I will do this, -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html