"Cousson, Benoit" <b-cousson@xxxxxx> writes: > On 3/14/2012 9:59 PM, Kevin Hilman wrote: >> Benoit Cousson<b-cousson@xxxxxx> writes: >> >>> From: Felipe Balbi<balbi@xxxxxx> >>> >>> With sparse IRQs the driver shouldn't depend at all on >>> any IRQ values coming from board-file. >>> >>> Remove every occurences of pdata->irq_base/end. >> >> Well, not quite *every*. :) > > Hehe, good catch, thanks. > >> If the driver isn't going to use those fields anymore, they should also >> be removed from the pdata struct too[1]. Also, the remaining board/init >> code that is initializing those fields should be removed as well[2], since >> it obviously has no effect. >> >> The first patch below should probably be folded into this one, and then >> the 2nd patch removes all the users. > > We should probably remove all the users before removing the attribute? > It looks like your patches are ordered in the opposite way. Agreed. > I'll add that in the series and repost the pull request. Great, thanks. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
