On Tue, Mar 13, 2012 at 05:26, <jean.pihet@xxxxxxxxxxxxxx> wrote:
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c
> b/arch/arm/mach-omap2/smartreflex.c
> index 7977018..dfe8075 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
...
> + switch (sr->ip_type) {
> + case SR_TYPE_V1:
> + value = notifier_to_irqen_v1(sr_class->notify_flags);
> + sr_modify_reg(sr, ERRCONFIG_V1, value,
> + (enable) ? value : 0);
> + break;
> + case SR_TYPE_V2:
> + value = notifier_to_irqen_v2(sr_class->notify_flags);
> + sr_write_reg(sr, (enable) ? IRQENABLE_SET : IRQENABLE_CLR,
> + value);
> + break;
> + default:
> + dev_warn(&sr->pdev->dev, "%s: unknown type of sr??\n",
> + __func__);
> + return -EINVAL;
> + }
> +
> + if (!enable)
> + sr_write_reg(sr, IRQSTATUS, value);
can you move this to before we disable the interrupt? it took a while,
but we caught a bug recently when we disable IRQ and then attempt to
clear the status[1]
Regards,
Nishanth Menon
[1] http://review.omapzoom.org/#/c/20231/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
