On Wednesday 07 March 2012 12:16 PM, Tarun Kanti DebBarma wrote: > In omap_gpio_runtime_resume() the context restore should be independent > of bank->enabled_non_wakeup_gpios. This was preventing context restore > of GPIO lines which are not wakeup enabled. > > Reported-by: Govindraj Raja <govindraj.raja@xxxxxx> > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx> > --- > drivers/gpio/gpio-omap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 2e8e476..ccfbae0 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -1227,7 +1227,7 @@ static int omap_gpio_runtime_resume(struct device *dev) > __raw_writel(bank->context.risingdetect, > bank->base + bank->regs->risingdetect); > > - if (!bank->enabled_non_wakeup_gpios || !bank->workaround_enabled) { > + if (!bank->workaround_enabled) { This doesn't seem to be right. Don't you want to avoid GPIO restore for banks which are in always on domain. Infact the purpose of "enabled_non_wakeup_gpios" is exactly that ? Isn't it. What am I missing ? Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html