"Govindraj.R" <govindraj.raja@xxxxxx> writes: > From: "Govindraj.R" <govindraj.raja@xxxxxx> > > On beagle some of uart mux lines are used for other > purpose so init only uart3. OK, but you should also be clear that this patch is effectively disabling all UARTS (except UART3) by defatul, which I'm not sure all Beagle users will be happy about. > Uart2 rx line clashes with gpio_147 used for usb ehci > phy reset. Initializing uart2 pad_mux lines can break > ehci module on beagle xm. > (gpio_147 is available on uart2_rx in mode4 reference > mux34xx.c -> uart2_rx.gpio_147) As Koen mentioned, this conflict only exists on certain boards, so you should be clear that this is just an example. > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > Cc: Kevin Hilman <khilman@xxxxxx> > Tested-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > Tested-by: Robert Nelson <robertcnelson@xxxxxxxxx> > Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> [...] > + > +static inline void board_serial_init(void) Should be __init [...] > +static inline void board_serial_init(void) here too. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
