Hi On Fri, 2 Mar 2012, Hiremath, Vaibhav wrote: > Paul, > Thanks for your review comments, can we also align on the approach, > Whether to merge am33xx powerdomain with omap4 (same direction we are now) > OR > Have separate implementation (my original approach). Could you please take a look at the "am335x_prcm_devel_3.4" branch on git://git.pwsan.com/linux-2.6 and let me know what you think? It is still rough, incomplete, and compile-tested only; and the patch commit messages have to be updated and revised; but I think it is a slightly better approach. A significant change is that the prminst code changes have been removed. That is only needed when PRM registers are spread across multiple PRCM IP blocks. This does not appear to be the case with AM33xx? So the implementation has been modified to create a prm33xx.c file instead. This avoids an extra, unnecessary layer of indirection for PRM accesses. This, along with the other differences between OMAP4 and this chip, means that a separate powerdomain33xx.c file had to be created. The powerdomains33xx_data.c file is still missing the bitmask position data, but the structure members are there. Feel free to combine, rework, or merge this series with what you are working on if you feel that it is a good approach. Otherwise, let's discuss. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
