On Tuesday 21 February 2012 09:38 PM, Tomi Valkeinen wrote:
On Tue, 2012-02-21 at 19:36 +0530, Archit Taneja wrote:
From: Lajos Molnar<lajos@xxxxxx>
If DSS is suspended during a wait_for_vsync operation, it may loose its clock.
Request runtime_pm around wait_for_vsync.
Signed-off-by: Lajos Molnar<lajos@xxxxxx>
Signed-off-by: Archit Taneja<archit@xxxxxx>
---
drivers/video/omap2/dss/dispc.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
This only handles omap_dispc_wait_for_irq_interruptible_timeout(),
there's also omap_dispc_wait_for_irq_timeout().
However, I think it'd be better to do the runtime_get/put in the caller,
instead of in these dispc's wait funcs. While it doesn't really matter
with dss_mgr_wait_for_vsync(), for dss_mgr/ovl_wait_for_go() it makes
much more sense to get/put there just once, instead of every time the
omap_dispc_wait_* is called.
Right, that makes sense. Btw, in the current code, how do we ensure that
clocks are enabled when someone calls omap_dss_mgr_apply().
Archit
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
