Hello. On 17-02-2012 14:34, Tero Kristo wrote:
Non-smp platforms don't have local timer support, but the twd_cpufreq_init only checks for IS_ERR during init. Check against null also, to avoid crashes during cpufreq transitions on non-smp platforms.
Signed-off-by: Tero Kristo <t-kristo@xxxxxx> --- arch/arm/kernel/smp_twd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 4285daa..dae8902 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -129,7 +129,7 @@ static struct notifier_block twd_cpufreq_nb = { static int twd_cpufreq_init(void) { - if (!IS_ERR(twd_clk)) + if (twd_clk&& !IS_ERR(twd_clk))
Why not !IS_ERR_OR_NULL(twd_clk)? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html