Re: [PATCH v3] i2c: fix missing handling of errata I2C_OMAP3_1P153

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,


On Fri, Feb 17, 2012 at 5:49 PM, Tasslehoff Kjappfot
<tasskjapp@xxxxxxxxx> wrote:
> From 0195dcf606b0ad069d8b5bc56cb877ff65ebea22 Mon Sep 17 00:00:00 2001
>
> From: Tasslehoff Kjappfot <tasskjapp@xxxxxxxxx>
> Date: Mon, 6 Feb 2012 14:14:23 +0100
> Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153
>
> i2c_probe set the dev->errata flag, but omap_i2c_init cleared the flag
> again. Move the errata handling to i2c_probe.
>
Looks good to me.
Reviewed-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
>
> Signed-off-by: Tasslehoff Kjappfot <tasskjapp@xxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-omap.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 801df60..d609ae2 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
>        /* Take the I2C module out of reset: */
>        omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN);
>
> -       dev->errata = 0;
> -
> -       if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207)
> -               dev->errata |= I2C_OMAP_ERRATA_I207;
> -
>        /* Enable interrupts */
>        dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY |
>                        OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK |
> @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev)
>
>        dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff;
>
> +       dev->errata = 0;
> +
> +       if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207)
> +               dev->errata |= I2C_OMAP_ERRATA_I207;
> +
>        if (dev->rev <= OMAP_I2C_REV_ON_3430)
>                dev->errata |= I2C_OMAP3_1P153;
>
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
>
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux