On Thu, 2012-02-16 at 11:36 -0800, Kevin Hilman wrote:
> Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes:
>
> > Hi Kevin,
> >
> > On Thu, Feb 16, 2012 at 11:20 AM, Kevin Hilman <khilman@xxxxxx> wrote:
> >> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> >> index 8a36342..140c032 100644
> >> --- a/arch/arm/mach-omap2/voltage.c
> >> +++ b/arch/arm/mach-omap2/voltage.c
> >> @@ -89,6 +89,8 @@ int voltdm_scale(struct voltagedomain *voltdm,
> >> ret = voltdm->scale(voltdm, target_volt);
> >> if (!ret)
> >> voltdm->nominal_volt = target_volt;
> >> + printk("KJH: %s: %d\n", __func__, target_volt);
> >> + dump_stack();
> > The debugging letfovers need to be removed.
>
> heh, that's why it's RFT. :)
<snip>
I tested this out with performance governor and limiting the
max_scaling_freq to different numbers. Clock frequency seems to change
based on arm_fck/rate debugfs entry, and the voltage is changing based
on both measurement and microvolts entry for the regulator.
However, twd_update_frequency crashes on omap3, as it doesn't have local
timer support but smp_twd registers a cpufreq notifier anyways.
Following patch fixes this issue (I'll send this out to l-o and l-arm
lists separately in a bit):
---
arch/arm/kernel/smp_twd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 4285daa..dae8902 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -129,7 +129,7 @@ static struct notifier_block twd_cpufreq_nb = {
static int twd_cpufreq_init(void)
{
- if (!IS_ERR(twd_clk))
+ if (twd_clk && !IS_ERR(twd_clk))
return cpufreq_register_notifier(&twd_cpufreq_nb,
CPUFREQ_TRANSITION_NOTIFIER);
--
1.7.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
