Hi Tomi, Thanks for your comments. On Mon, 2012-02-13 at 15:48 +0200, Tomi Valkeinen wrote: > Hi, > > On Sat, 2012-02-11 at 17:55 -0600, Ricardo Neri wrote: > > The functions dss_init_hdmi_ip_ops and dss_has_feature are used by > > the ASoC HDMI codec. Both the ASoC codec and DSS may be built > > as separate kernel modules. Hence, these two functions need to be > > available for dynamic linking. > > Neither of those functions should be exported, they are omapdss > internal. And you had to hack around to make those usable by adding > drivers/video/omap2/dss into the include path. > > Anything that is exported from omapdss should be added to > include/video/omapdss.h. Users of omapdss should never include anything > from drivers/video/omap2/dss. > > But as I said, neither of those functions should be exported, they are > clearly omapdss internal functions. For dss_has_feature we probably need > a new function to convey the information about the hdmi features that > the audio side needs. Or perhaps it can be in the ip_data. I will try to create this new functions and add it to include/video/omapdss.h and resubmit the patch. The approach that I am following is to maintain an hdmi_ip_data structure in the ASoC HDMI codec driver to utilize the functions of the HDMI IP library. If the DSS features are stored in the ip_data then I would need a DSS function (i.e., dss_features_init or similar) to initialize it. This may not be right as that is an omapdss internal function. > > For dss_init_hdmi_ip_ops I don't see why the audio part should see it. > Initializing the ops should clearly be done by omapdss automatically. Yes, the DSS HDMI driver already does this for its own struct hdmi_ip_data. However, under my approach, the hdmi_ip_data of the ASoC HDMI driver needs to be initialized as well. Another approach is to not have an hdmi_ip_data in the ASoC HDMI driver and reuse the ip_data of the DSS HDMI driver. In that case, however, a lot of set/get functions would need to be implemented in DSS to expose audio functionality: HDMI mode, deep color configuration, audio infoframe config and core and wrapper configuration for audio. An example of this is already present in here: http://www.spinics.net/lists/linux-omap/msg64479.html Being HDMI special as no other display combines audio and video, maybe a special header file could be created for HDMI. What do you think? Ricardo > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
